Hi Tekman, Yes, that's part of it as well, I added a vcpkg port for 8.3 too but now I tried to update to 8.5 and the PR won't merge because with the mingw side of things the patches become too big for the vcpkg repo 🤷♀️ Full story: https://github.com/microsoft/vcpkg/pull/13355
I need mingw because that's what I like and what I use to develop, I want vcpkg because I keep my projects in sync mingw/msvc/linux. I can't link to the MSVC libs from mingw because of the ABI, so I guess if push comes to shove, I could do with a personal vcpkg fork, but that's not my ideal. On Tuesday, October 27, 2020 at 2:46:41 PM UTC-6 Tekman wrote: > What about working on a more official MSVC build support? There are other > projects (like node.js) building with MSVC, but since Chromium dropped that > support, V8's build often needs patching and feels like it's on its last > legs. > > The good news is that as of 8.6 (and with a few patches we can backport > from node) we can actually build all Windows platforms / architectures / > flavors, so it would be easier to build vcpkg portfiles or whatever else on > top of that existing support (of course, having a few build bots / CI > configs testing the config doesn't break would be marvelous). > > > > On Tuesday, October 27, 2020 at 1:35:58 PM UTC-7 [email protected] > wrote: > >> Thank you Jakob, >> >> I am fine with that, it is not my intention to do a code drop and forget >> about it, my intention is to keep the configuration valid for as long as I >> can within my own constraints. >> >> I am also aware that the build directory belongs to the overarching >> chromium project, unfortunately most of the changes belong in there, these >> patches add a new toolchain after all. >> in particular I am adding a is_mingw gn variable similar to the is_clang >> variable which is frowned upon from what I can gather. >> >> Anyway, just wanted to know if there is any possible animosity towards >> the changes before working on a code review and have it shut down right >> away. >> >> Thanks Again. >> >> On Tuesday, October 27, 2020 at 12:41:30 PM UTC-6 Jakob Kummerow wrote: >> >>> Historically, we've been fine with accepting (reasonably non-intrusive) >>> patches to fix/improve MinGW support. Note that this does not mean that we >>> would officially support/maintain/test that configuration; we would >>> continue to rely on community support (i.e. people like you) to notice and >>> fix any breakage. >>> >>> Also, note that the build/ directory is DEPS'ed in, i.e. you would have >>> to submit those changes to Chromium rather than V8. I don't know how the >>> Chromium project thinks about MinGW these days. >>> >>> >>> On Tue, Oct 27, 2020 at 5:31 PM Rodrigo Hernandez < >>> [email protected]> wrote: >>> >>>> Hello, >>>> >>>> Early this year I took on the task to make v8 build using msys2 mingw, >>>> between July and August I was successful in doing so, I submitted a >>>> patchset >>>> and build script to the msys-mingw project and now there is an official >>>> mingw-w64 v8 package for 32 bit as well as 64 bit. >>>> >>>> You can see the patches required here: >>>> >>>> https://github.com/msys2/MINGW-packages/tree/master/mingw-w64-v8 >>>> >>>> So, in order to reduce the size of the patches (or remove them >>>> altogether), I was wondering whether this is something v8 developers would >>>> be interested in so it can be merged upstream. >>>> >>>> Thanks! >>>> >>>> -- >>>> -- >>>> v8-dev mailing list >>>> [email protected] >>>> http://groups.google.com/group/v8-dev >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "v8-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/v8-dev/f620d142-e08e-4d9e-bb18-8003b0f88452n%40googlegroups.com >>>> >>>> <https://groups.google.com/d/msgid/v8-dev/f620d142-e08e-4d9e-bb18-8003b0f88452n%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/112355b7-a9d8-4d3a-80fa-9ae3f52f12abn%40googlegroups.com.
