Reviewers: fschneider, Description: Version 2.1.2.3 Revert use of store IC for array length
This reverts the effect of r3902 (I could not get svn merge to revert it). This
fixes the Chromium regression for the chrome://extensions URL. BUG=http://crbug.com/36854 TEST=none Please review this at http://codereview.chromium.org/661174 SVN Base: http://v8.googlecode.com/svn/trunk/ Affected files: M src/ic.cc M src/version.cc Index: src/ic.cc =================================================================== --- src/ic.cc (revision 3966) +++ src/ic.cc (working copy) @@ -1049,20 +1049,6 @@ return *value; } - - // Use specialized code for setting the length of arrays. - if (receiver->IsJSArray() - && name->Equals(Heap::length_symbol()) - && receiver->AllowsSetElementsLength()) { -#ifdef DEBUG - if (FLAG_trace_ic) PrintF("[StoreIC : +#length /array]\n"); -#endif - Code* target = Builtins::builtin(Builtins::StoreIC_ArrayLength); - set_target(target); - StubCache::Set(*name, HeapObject::cast(*object)->map(), target); - return receiver->SetProperty(*name, *value, NONE); - } - // Lookup the property locally in the receiver. if (FLAG_use_ic && !receiver->IsJSGlobalProxy()) { LookupResult lookup; Index: src/version.cc =================================================================== --- src/version.cc (revision 3966) +++ src/version.cc (working copy) @@ -35,7 +35,7 @@ #define MAJOR_VERSION 2 #define MINOR_VERSION 1 #define BUILD_NUMBER 2 -#define PATCH_LEVEL 2 +#define PATCH_LEVEL 3 #define CANDIDATE_VERSION false // Define SONAME to have the SCons build the put a specific SONAME into the -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
