Revision: 3967 Author: [email protected] Date: Fri Feb 26 03:42:58 2010 Log: Version 2.1.2.3 Revert use of store IC for array length
This reverts the effect of r3902 (I could not get svn merge to revert it). This fixes the Chromium regression for the chrome://extensions URL.
BUG=http://crbug.com/36854 TEST=none Review URL: http://codereview.chromium.org/661174 http://code.google.com/p/v8/source/detail?r=3967 Modified: /trunk/src/ic.cc /trunk/src/version.cc ======================================= --- /trunk/src/ic.cc Fri Feb 19 00:53:10 2010 +++ /trunk/src/ic.cc Fri Feb 26 03:42:58 2010 @@ -1048,20 +1048,6 @@ if (result.is_null()) return Failure::Exception(); return *value; } - - - // Use specialized code for setting the length of arrays. - if (receiver->IsJSArray() - && name->Equals(Heap::length_symbol()) - && receiver->AllowsSetElementsLength()) { -#ifdef DEBUG - if (FLAG_trace_ic) PrintF("[StoreIC : +#length /array]\n"); -#endif - Code* target = Builtins::builtin(Builtins::StoreIC_ArrayLength); - set_target(target); - StubCache::Set(*name, HeapObject::cast(*object)->map(), target); - return receiver->SetProperty(*name, *value, NONE); - } // Lookup the property locally in the receiver. if (FLAG_use_ic && !receiver->IsJSGlobalProxy()) { ======================================= --- /trunk/src/version.cc Fri Feb 26 02:06:16 2010 +++ /trunk/src/version.cc Fri Feb 26 03:42:58 2010 @@ -35,7 +35,7 @@ #define MAJOR_VERSION 2 #define MINOR_VERSION 1 #define BUILD_NUMBER 2 -#define PATCH_LEVEL 2 +#define PATCH_LEVEL 3 #define CANDIDATE_VERSION false // Define SONAME to have the SCons build the put a specific SONAME into the -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
