Reviewers: Lasse Reichstein, Message: TBR: lrn
Description: Moved initialization of xmm3 making sure it is initialized on all paths in GeneratePow - solves the sputnik failure on mac. Committed: http://code.google.com/p/v8/source/detail?r=3973 Please review this at http://codereview.chromium.org/661177 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/ia32/codegen-ia32.cc Index: src/ia32/codegen-ia32.cc =================================================================== --- src/ia32/codegen-ia32.cc (revision 3966) +++ src/ia32/codegen-ia32.cc (working copy) @@ -5296,6 +5296,10 @@ ASSERT(x.is_valid()); ASSERT(y.is_valid()); + // Save 1 in xmm3 - we need this several times later on + __ mov(p.reg(), Immediate(1)); + __ cvtsi2sd(xmm3, Operand(p.reg())); + Label y_nonsmi; Label x_is_double; // If y is a heap number go to that specific case. @@ -5321,10 +5325,8 @@ // Save y in x as we need to check if y is negative later. __ mov(x.reg(), y.reg()); - // Save 1 in xmm3 - we need this several times later on - __ mov(p.reg(), Immediate(1)); - __ cvtsi2sd(xmm3, Operand(p.reg())); + // Get absolute value of y. Label no_neg; __ cmp(y.reg(), 0); -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
