I'd group the changes by "topic", or kind of change. (It's a bit hard to say in the abstract, without having seen the changes.)
E.g. I guess you'll add a new src/base/platform/, that could be its own CL. More generally: - any reasonably self-contained thing/concept that you're adding can be its own CL. - if you're making the same type of mechanical change (renaming, adding #includes, ...) across the codebase, one such change (or a group of tightly coupled / very similar changes) can be its own CL. - if those criteria aren't enough to get to manageable CL sizes, split by paths (e.g. src/base/, src/*, test/cctests/, test/unittests/, ...). For the definition of "manageable", ask yourself what you'd like to review. As a rough guideline, if it's more than 500 lines or more than 20 files at once, I'd ask whether that's really the smallest unit that makes sense. (Sometimes it is!) On Fri, Sep 24, 2021 at 6:51 PM Gaby Baghdadi <[email protected]> wrote: > Hi. I'd like to upload changes to V8, build and icu repositories to enable > V8 to build on z/OS (which runs on the s390 platforms that are already > supported with Linux). > > The 'git diff' for the V8 changes is about 4000 lines, and affects some > 150 src/, include/, test/, etc. files. Please advise on how to break up the > upload, or if all changes should be uploaded in a single patch. > > Thanks. > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/cd743160-e23f-4148-8269-5f90d639854en%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/cd743160-e23f-4148-8269-5f90d639854en%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAKSzg3TBoEhc%3DaAgLLtCLCyA1%2ByCFxE22Pmu0XGn00JjEToZhA%40mail.gmail.com.
