It's already been fixed in https://github.com/nodejs/node/pull/40670
On Mon, Nov 1, 2021 at 6:27 PM Lei Wang <[email protected]> wrote: > Hi Victor & Yahan, > > Seems it's daylight saving time (DST) which causes the problem. I noticed > that the failed test case was introduced in commit 80ed0a66b5a > on 2021-05-20, which didn't cover the DST case. Today (2021-11-01 Mon) is > the first day of the Europe DST, that's why you encountered the problem. > > I'd like to submit a fix to nodejs. > > On Mon, Nov 1, 2021 at 5:38 PM 'Victor Gomes' via v8-dev < > [email protected]> wrote: > >> Hi Yahan, >> >> The log shows an error in the test parallel/test-datetime-change-notify >> <https://github.com/nodejs/node/blob/master/test/parallel/test-datetime-change-notify.js> >> . >> Your CL does not seem to change anything related to this test, so I >> suppose it is either flaky or some recent ICU roll broke it. >> >> Today is a bank holiday in Germany, but I will have a better look >> tomorrow. >> >> If you are in a rush, you can create a CL/PR ( >> https://github.com/v8/node/tree/node-ci-2021-10-12) disabling the test >> (in parallel.status >> <https://github.com/nodejs/node/blob/master/test/parallel/parallel.status>) >> and send it to me. >> More info: https://v8.dev/docs/node-integration >> >> Best, >> Victor >> >> >> not ok 660 parallel/test-datetime-change-notify --- duration_ms: 0.161 >> severity: fail exitcode: 1 stack: |- node:assert:1021 throw err; ^ >> AssertionError [ERR_ASSERTION]: The input did not match the regular >> expression /Irish/. Input: '11/1/2021, 6:18:16 AM Greenwich Mean Time' at >> Object.<anonymous> >> (/b/s/w/ir/cache/builder/node-ci/node/test/parallel/test-datetime-change-notify.js:36:10) >> at Module._compile (node:internal/modules/cjs/loader:1095:14) at >> Object.Module._extensions..js (node:internal/modules/cjs/loader:1147:10) at >> Module.load (node:internal/modules/cjs/loader:975:32) at >> Function.Module._load (node:internal/modules/cjs/loader:822:12) at >> Function.executeUserEntryPoint [as runMain] >> (node:internal/modules/run_main:81:12) at >> node:internal/main/run_main_module:17:47 { generatedMessage: true, code: >> 'ERR_ASSERTION', actual: '11/1/2021, 6:18:16 AM Greenwich Mean Time', >> expected: /Irish/, operator: 'match' } Node.js v17.0.0-pre ... >> >> On Mon, Nov 1, 2021 at 7:41 AM Yahan Lu <[email protected]> wrote: >> >>> >>> https://ci.chromium.org/ui/p/node-ci/builders/try/node_ci_linux64_rel/b8831788584046269361/overview >>> >>> I can't find any error info >>> >>> -- >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/v8-dev/a1881411-48b8-4f07-a2ad-17919b1fc0e9n%40googlegroups.com >>> <https://groups.google.com/d/msgid/v8-dev/a1881411-48b8-4f07-a2ad-17919b1fc0e9n%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> >> >> -- >> Victor >> >> -- >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/v8-dev/CAGFuzY1NXG2OhcU7Zg_7Yu_BOnWG%3DjR1MuAuKjGRTQissDqy0w%40mail.gmail.com >> <https://groups.google.com/d/msgid/v8-dev/CAGFuzY1NXG2OhcU7Zg_7Yu_BOnWG%3DjR1MuAuKjGRTQissDqy0w%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAH51GNua%2BWAowx10LCP0OmED_h8Pt-%2B4f%2Bb%2B2zcp5-aWrV_tzg%40mail.gmail.com.
