Thanks, please submit a CL. The 'merge request' you refer to means merging back to (beta/stable) branches.
On Fri, Dec 3, 2021 at 4:50 PM Jiading Guo <[email protected]> wrote: > Hi all, > > In `tools/gen-keywords-gen-h.py`[1] > > if (IsInRange(len, MIN_WORD_LENGTH, MAX_WORD_LENGTH)) > > should be > > if (base::IsInRange(len, MIN_WORD_LENGTH, MAX_WORD_LENGTH)) > > This commit[2] introduced base namespace but didn't change the python > script accordingly. I read from doc[3] that merge request only accept > severe bug fix, so I'll drop this tiny fix in the mailing list. > > Regards, > Jiading > > [1] > https://source.chromium.org/chromium/chromium/src/+/main:v8/tools/gen-keywords-gen-h.py;l=86;drc=fcd0cf445426fb2a2d0079c50e3d16026a13295e > [2] https://chromium-review.googlesource.com/c/v8/v8/+/1916604 > [3] https://v8.dev/docs/merge-patch > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/b527c561-b176-445a-af7d-e12aa0505ce7n%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/b527c561-b176-445a-af7d-e12aa0505ce7n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAH3p7oNSO4_vJ2bBUb-dKxd0ey1AD3q_Z5o4e93bLfOYmB%3DE2A%40mail.gmail.com.
