On Tue, Mar 1, 2022 at 4:54 PM '[email protected]' via v8-dev < [email protected]> wrote:
> Thanks, Leszek! This issue is high priority for Microsoft because it > affects Office Online, so we'd be happy to provide the implementation with > your guidance and code reviews. > > > we could in fact make the isolate script cache entries always be Scripts > > Would that option cause a lower hit rate? The current implementation keeps > the root SFI alive until its bytecode gets flushed, meaning it survives > five GC cycles after nobody is using it. If we only held a pointer to the > Script, then I imagine the root SFI could get collected earlier since the > Script points to its SFIs only via a WeakFixedArray. > Ah yes, good point, in which case it makes sense to either hold both the script and root SFI, or swap the root SFI with the Script as you suggested. -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAGRskv-keqjZ8jttH6maUx4DLRAYfLFbvz4U%3DKBkBefZmJ%2BytQ%40mail.gmail.com.
