Note that this happens in release mode (with assertions disabled); the variable aborted_pages_verified is used in a DCHECK.
Glog defines DCHECK in release mode carefully so it doesn't trigger this warning; v8 defines it as ((void)0). Still, any suggestions? Thanks, -Tudor. On Wednesday, April 20, 2022 at 1:10:51 PM UTC-7 Tudor Bosman wrote: > Hello, > > It seems to me that a recent clang upgrade made -Wextra more strict and v8 > now fails to build: > > > ../../src/heap/mark-compact.cc:4748:10: error: variable > 'aborted_pages_verified' set but not used > [-Werror,-Wunused-but-set-variable] > > size_t aborted_pages_verified = 0; > > ^ > > 1 error generated. > > These are the commands I'm using to build: > > export PATH="/src/depot_tools:$PATH" > echo "--- leafagg_dev building v8 -- $(date -Iseconds)" \ > && apt-get -qq install python2 \ > && cd /src \ > && git clone > https://chromium.googlesource.com/chromium/tools/depot_tools.git \ > && hash -r \ > && mkdir v8 \ > && cd v8 \ > && fetch v8 \ > && gclient sync \ > && cd v8 \ > && git checkout 10.0.139.15 \ > && python2 tools/dev/v8gen.py x64.release.sample -- use_rtti=true \ > && ninja -C out.gn/x64.release.sample v8_monolith > > Full logs <https://gist.github.com/tudor/e38a9203d2b02d1f9750a40193c4d4c6> > (long and spammy). > > Any suggestions? > > Thank you, > -Tudor. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/c24be11d-3598-4ab3-8521-003b10b7f4b5n%40googlegroups.com.
