Thanks, patch in flight: https://chromium-review.googlesource.com/c/v8/v8/+/3776339
On Wed, Jul 20, 2022 at 3:56 AM Paul Harris <[email protected]> wrote: > I had this same issue. > This user had the same problem: > https://groups.google.com/g/v8-users/c/aVnVmDKkt8Q/m/jBSsug5tAAAJ > > I notice that v8_heap_base_headers is a header-only target in BUILD.gn, > but it is defined as "v8_source_set()" which ends up as a lib. > > If you change the line in BUILD.gn: > v8_source_set("v8_heap_base_headers") { > to > v8_header_set("v8_heap_base_headers") { > > It is around the line 5544 or 5653 depending on which version you are > looking at. > > It changes to a virtual target, doesn't build a lib, and works! > > Note that "gn" source_set() normally builds virtual targets, but the > v8_source_set() seems to behave differently. > > > DEVS can you please patch the BUILD.gn file if you agree? > I'm not in a position to make a PR/MR/contribution right now. > > Thanks! > Paul > > > On Thursday, April 14, 2022 at 6:52:05 PM UTC+8 [email protected] wrote: > >> Hello, >> >> I'm not able to build chromium for windows 11 OS. >> >> Flags used: >> is_official_build=true >> use_custom_libcxx=true >> t5_support_partition_alloc=false >> t5_single_threaded=false >> t5_enable_freetype=false >> v8_enable_i18n_support=false >> v8_static_library=true >> v8_use_external_startup_data=false >> >> >> FAILED: mksnapshot.exe mksnapshot.exe.pdb >> ..\..\..\..\..\..\..\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe >> /OUT:./mksnapshot.exe /nologo >> -libpath:..\..\..\..\..\..\..\chromium\src\third_party\llvm-build\Release+Asserts\lib\clang\15.0.0\lib\windows >> "-libpath:../../../../../../../../../../../../../Program Files >> (x86)/Microsoft Visual >> Studio/2019/Community/VC/Tools/MSVC/14.29.30133/ATLMFC/lib/x64" >> "-libpath:../../../../../../../../../../../../../Program Files >> (x86)/Microsoft Visual >> Studio/2019/Community/VC/Tools/MSVC/14.29.30133/lib/x64" >> "-libpath:../../../../../../../../../../../../../Program Files >> (x86)/Windows Kits/NETFXSDK/4.8/lib/um/x64" >> "-libpath:../../../../../../../../../../../../../Program Files >> (x86)/Windows Kits/10/lib/10.0.22000.0/ucrt/x64" >> "-libpath:../../../../../../../../../../../../../Program Files >> (x86)/Windows Kits/10/lib/10.0.20348.0/um/x64" /MACHINE:X64 >> /PDB:./mksnapshot.exe.pdb @./mksnapshot.exe.rsp >> lld-link: error: could not open 'obj/v8/v8_heap_base_headers.lib': no >> such file or directory >> >> Same code works fine and build is successful in mac OS. >> >> Any help in what i might be doing wrong or have to do extra in windows OS? >> > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/eccf4d53-5e4c-4d73-b5ce-ab451144aa1an%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/eccf4d53-5e4c-4d73-b5ce-ab451144aa1an%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAKSzg3QY0%2BKKAuzqJR%3DJ4ocP6Kx5v8_Du48%2BPMBXKZfOJJ%3D-aA%40mail.gmail.com.
