I added some owners for concerned files. I Hope that's the right way to do it 👍
On Friday, 23 September 2022 at 15:58:28 UTC+2 Pierrick Bouvier wrote: > I fixed all compilation errors found with MSVC 2019, for x64, and arm64. > Patches are here: > - https://chromium-review.googlesource.com/c/v8/v8/+/3913036 > - https://chromium-review.googlesource.com/c/v8/v8/+/3913035 > - https://chromium-review.googlesource.com/c/v8/v8/+/3913034 > - https://chromium-review.googlesource.com/c/v8/v8/+/3913033 > > I'll suggest you as a reviewer. Who could we add in more? > > Thanks a lot, > Pierrick > > On Thursday, 22 September 2022 at 15:01:53 UTC+2 Pierrick Bouvier wrote: > >> Thanks for your answer. >> >> I'll upstream that then. >> >> On Thursday, 22 September 2022 at 14:40:39 UTC+2 Jakob Kummerow wrote: >> >>> We support MSVC, though mostly on a best-effort basis, i.e. relying on >>> community contributions in particular for non-standard build configurations. >>> >>> We have buildbot coverage for MSVC on x64, not on ARM. I suspect that >>> that'll remain that way, but it's not my decision to make. >>> >>> +1 to upstreaming the patch. See https://v8.dev/docs/contribute for >>> details. >>> >>> >>> On Thu, Sep 22, 2022 at 11:38 AM Pierrick Bouvier < >>> [email protected]> wrote: >>> >>>> Hello, >>>> >>>> I'm currently investigating v8 build for Windows on Arm, for NodeJS >>>> project. >>>> They are trying to update to latest version of v8, and a build error is >>>> present (using VS2019). >>>> https://github.com/nodejs/node-v8/issues/240 >>>> >>>> I was able to write a patch for v8, and I would like to upstream it >>>> (details in github issue). >>>> >>>> Does building with msvc is still supported as of today? If no, NodeJS >>>> will have to live with this patch. >>>> If yes, is there a build bot setup for this? >>>> >>>> Thanks, >>>> Pierrick >>>> >>>> -- >>>> -- >>>> v8-dev mailing list >>>> [email protected] >>>> http://groups.google.com/group/v8-dev >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "v8-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/v8-dev/94208a37-94f2-4f08-8503-6020ed20304fn%40googlegroups.com >>>> >>>> <https://groups.google.com/d/msgid/v8-dev/94208a37-94f2-4f08-8503-6020ed20304fn%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/6b5d35d3-8248-44bc-bbc9-67c89d967884n%40googlegroups.com.
