On Wed, Feb 15, 2023 at 1:44 AM Kwasi Mensah <[email protected]> wrote:
> Hi v8-dev, > > I was debugging something that was causing me to place extra GCs and saw > that it was causing a ton of spurious turbofan recompilation of functions > and deopts referencing weak objects. After digging a bit it looks like v8 > only keeps a weak reference to optimized code in > https://github.com/v8/v8/blame/main/src/objects/feedback-vector.cc#L368 > Are you sure it would help? The 'deopts referencing weak objects' sound unrelated since the referenced objects are probably not optimized code. And deoptimized TF code cannot be reused, so I don't see how we could avoid the recompilation through a strong reference in the FeedbackVector in this case. Please try your proposal locally first before considering adding a flag. > > > It looks like it's done this from the beginning per > https://github.com/v8/v8/commit/11a211ff1b81e8d83d1aa4898743c2efb89603bd#diff-cbddb8a6da7810e9fc3647c9cf4f511410c43d11da9f62873bc33dece03a31f5R305 > > I'm writing a CLI using node and I'm willing to trade memory for speed. Is > this a contribution that makes sense behind an experimental flag? > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/5136347a-c0f6-4bf1-b8dc-9ee596755441n%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/5136347a-c0f6-4bf1-b8dc-9ee596755441n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAH3p7oMFL_3XJ_vGNSyn%2B4i7rRdzv8CO2kToKwVFVmp_cTuzhw%40mail.gmail.com.
