Thanks for confirming. Fix is in flight:
https://chromium-review.googlesource.com/c/v8/v8/+/4756844
On Mon, Aug 7, 2023 at 1:28 PM Meir Shpilraien <m...@redis.com> wrote:
> Thanks Jakob,
>
> You are right, I do use `use_custom_libcxx = false`, I just tested
> without it and it compiled successfully so I guess this is really the issue.
> Here is the rest of my compilation options (if its still relevant):
> `v8_monolithic=true v8_use_external_startup_data=false
> treat_warnings_as_errors=false is_component_build=false use_custom_libcxx =
> false`.
>
> Thanks,
> Meir
>
> On Monday, 7 August 2023 at 12:33:35 UTC+3 Jakob Kummerow wrote:
>
>> Hi Meir,
>>
>> Thanks for reporting this. That's a new check that we recently
>> introduced. It is unfortunately toolchain-dependent, so presumably
>> something about the way you build is non-standard. As a guess: are you
>> building with `use_custom_libcxx = false`? That reproduces similar failures
>> for me locally. I'll fix those later today. If there's something else
>> that's different for your setup, please let me know.
>>
>> Cheers,
>> Jakob
>>
>>
>> On Sun, Aug 6, 2023 at 5:27 PM Meir Shpilraien <me...@redis.com> wrote:
>>
>>> Hey,
>>>
>>> Recently we started to get an error when building the main branch on
>>> debug mode.
>>> The error we get:
>>>
>>> ```
>>> ../../src/wasm/wasm-module.cc:618:3: error: static assertion failed due
>>> to requirement 'sizeof(v8::internal::wasm::WasmModule) == 848': Update
>>> {EstimateCurrentMemoryConsumption} when adding fields to WasmModule
>>> 618 | UPDATE_WHEN_CLASS_CHANGES(WasmModule, 848);
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> ../../src/wasm/std-object-sizes.h:69:17: note: expanded from macro
>>> 'UPDATE_WHEN_CLASS_CHANGES'
>>> 69 | static_assert(sizeof(classname) == size,
>>> \
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>>> ../../src/wasm/wasm-module.cc:618:3: note: expression evaluates to '896
>>> == 848'
>>> 618 | UPDATE_WHEN_CLASS_CHANGES(WasmModule, 848);
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> ../../src/wasm/std-object-sizes.h:69:35: note: expanded from macro
>>> 'UPDATE_WHEN_CLASS_CHANGES'
>>> 69 | static_assert(sizeof(classname) == size,
>>> \
>>> | ~~~~~~~~~~~~~~~~~~^~~~~~~
>>> ../../src/wasm/wasm-module.cc:673:3: error: static assertion failed due
>>> to requirement 'sizeof(v8::internal::wasm::TypeFeedbackStorage) == 160':
>>> Update {EstimateCurrentMemoryConsumption} when adding fields to
>>> TypeFeedbackStorage
>>> 673 | UPDATE_WHEN_CLASS_CHANGES(TypeFeedbackStorage, 160);
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> ../../src/wasm/std-object-sizes.h:69:17: note: expanded from macro
>>> 'UPDATE_WHEN_CLASS_CHANGES'
>>> 69 | static_assert(sizeof(classname) == size,
>>> \
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>>> ../../src/wasm/wasm-module.cc:673:3: note: expression evaluates to '176
>>> == 160'
>>> 673 | UPDATE_WHEN_CLASS_CHANGES(TypeFeedbackStorage, 160);
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> ../../src/wasm/std-object-sizes.h:69:35: note: expanded from macro
>>> 'UPDATE_WHEN_CLASS_CHANGES'
>>> 69 | static_assert(sizeof(classname) == size,
>>> \
>>> | ~~~~~~~~~~~~~~~~~~^~~~~~~
>>> ../../src/wasm/wasm-module.cc:691:3: error: static assertion failed due
>>> to requirement 'sizeof(v8::internal::wasm::WasmModule) == 848': Update
>>> {EstimateCurrentMemoryConsumption} when adding fields to WasmModule
>>> 691 | UPDATE_WHEN_CLASS_CHANGES(WasmModule, 848);
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> ../../src/wasm/std-object-sizes.h:69:17: note: expanded from macro
>>> 'UPDATE_WHEN_CLASS_CHANGES'
>>> 69 | static_assert(sizeof(classname) == size,
>>> \
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>>> ../../src/wasm/wasm-module.cc:691:3: note: expression evaluates to '896
>>> == 848'
>>> 691 | UPDATE_WHEN_CLASS_CHANGES(WasmModule, 848);
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> ../../src/wasm/std-object-sizes.h:69:35: note: expanded from macro
>>> 'UPDATE_WHEN_CLASS_CHANGES'
>>> 69 | static_assert(sizeof(classname) == size,
>>> \
>>> | ~~~~~~~~~~~~~~~~~~^~~~~~~
>>> 3 errors generated.
>>> ```
>>>
>>> We do not get this error on official version or on release build. I was
>>> wondering if we are doing something wrong or is it something that is broken
>>> currently?
>>>
>>> Thanks,
>>> Meir.
>>>
>>>
>>>
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/v8-dev/CAKSzg3R%2Bwgioj88%3D%3DyDADXDusDBkzpfHgCxhpib7tcLQ5DzDZw%40mail.gmail.com.
