On Sun, Feb 28, 2010 at 10:41 AM, Kevin Millikin <[email protected]>wrote:
> On Fri, Feb 19, 2010 at 2:40 PM, <[email protected]> wrote: > >> Reviewers: Erik Corry, iposva, >> >> Message: >> Changed as discussed. >> >> I had to check out v8 again due to issues with SVN. >> gcl upload created a new issue: >> >> http://codereview.chromium.org/651029 >> >> Is there a simple way to make gcl upload the changelist here? > > > gcl upload --issue=<number> > > or > > gcl upload -i <number> > > where <number> is the issue number Rietveld originally assigned. > I probably should have mentioned that I had tried this.... :) (but I do not remember the error message unfortunately). Since people have already commented on the new issue, it probably does not make sense to move it back any longer.... Thanks Stefan > > >> >> >> >> >> On 2010/02/16 06:51:35, iposva wrote: >> >>> I guess I do not understand the motivation to add a complete duplicate >>> copy of >>> the simulator to the system. Can you please elaborate your plans in that >>> respect? >>> >> >> Thanks, >>> -Ivan >>> >> >> >> >> Description: >> Forking disassembler and simulator for Thumb2 support; >> Limited experimental thumb2 support for AND and ADD >> >> >> >> Please review this at http://codereview.chromium.org/601028 >> >> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ >> >> Affected files: >> M src/SConscript >> M src/arm/assembler-arm.h >> >> M src/arm/assembler-thumb2-inl.h >> M src/arm/assembler-thumb2.h >> A src/arm/debug-thumb2.cc >> A src/arm/disasm-thumb2.cc >> A src/arm/instr-thumb2.cc >> M src/arm/regexp-macro-assembler-arm.cc >> A src/arm/simulator-thumb2.cc >> M src/simulator.h >> >> >> >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- Stefan Haustein Google UK Limited Registered Office: Belgrave House, 76 Buckingham Palace Road, London SW1W 9TQ; Registered in England Number: 3977902 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
