LGTM I actually think we are missing a cld instruction before rep_movs in StringStubBase::GenerateCopyCharactersREP.
http://codereview.chromium.org/661245/diff/1/4 File src/ia32/builtins-ia32.cc (right): http://codereview.chromium.org/661245/diff/1/4#newcode806 src/ia32/builtins-ia32.cc:806: Label* gc_required) { Please ASSERT array_size.is(ecx) at the begining of the function. Also make a comment about it. The same regarding the assumptions about array_function and scratch, see StringStubBase::GenerateCopyCharactersREP() http://codereview.chromium.org/661245 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
