This seems like a reasonable thing to do yes, I'll review your CL. On Wed, Sep 20, 2023 at 7:24 AM Yahan Lu <[email protected]> wrote:
> Do you have any opinion? > > 在2023年9月20日星期三 UTC+8 10:23:57<Yahan Lu> 写道： > >> Hello everyone~ >> I want to port maglev to RISC-V, but there is no conditional bit code in >> RISC-V >> So I need to remove the conditional bit code from the Maglev generic code. >> I opened a CL (https://chromium-review.googlesource.com/c/v8/v8/+/4876814) >> to remove CompareInt32 and replace it with CompareInt32AndJumpIf. >> >> If I can, I'll modify all cmp/assert in the maglev generic code. >> > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/ac54cfcc-b8e6-4362-b48a-52e38112e0a6n%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/ac54cfcc-b8e6-4362-b48a-52e38112e0a6n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAGRskv-vxStzr%3Dpnp%3DnMTFiTWTx-Zx3%2BR8FMqhAy%2BDwUYhc1XQ%40mail.gmail.com.
