On Wed, Oct 18, 2023 at 12:22 AM Luke Albao <lukeal...@gmail.com> wrote: > > Hello! > > I'm a node user, and I've traced a small bug to a change back in v8.x of v8. > I'd like to submit a patch, but I'm unsure of the best way to go about this. > It would be great to have this affect any downstream release that is used by > a supported Node version. > > It's a small change and I'd be thrilled to land it. Is that something I can > do in v8/v8, or should I try to land patches in nodejs/nodejs branches and > then get them back upstream? > > Thanks! > > Luke
Node.js maintainer and V8 committer speaking. The bug fix should first land in V8's ToT (tip-of-top). When merged, open a cherry-pick pull request to node's main branch. Your cherry-pick is normally back-ported to release branches automatically (first Current, then later LTS.) If it doesn't apply cleanly or causes test suite regressions, you'll get a ping on your pull request with a request to back-port it manually. If you have a fix for an issue that doesn't exist in upstream V8 anymore, you can open a node pull request targeting the affected branch directly but mention in the pull request why you're skipping the "upstream first" process, otherwise it'll get rejected out of hand. More details here: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-V8.md -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAHQurc_R9fTzhWWqoc-AsmVQKTdpevVSn9t9HBQ1wF0dhVJXMA%40mail.gmail.com.
