Good catch - thanks for doing this. Add the additional fixes, and LGTM.
http://codereview.chromium.org/660257/diff/1/2 File src/ia32/debug-ia32.cc (right): http://codereview.chromium.org/660257/diff/1/2#newcode153 src/ia32/debug-ia32.cc:153: // -- eax : key edx : receiver eax : key http://codereview.chromium.org/660257/diff/1/2#newcode162 src/ia32/debug-ia32.cc:162: // -- eax : value ecx : key edx : receiver http://codereview.chromium.org/660257/diff/1/2#newcode166 src/ia32/debug-ia32.cc:166: Generate_DebugBreakCallHelper(masm, eax.bit(), false); eax.bit() | ecx.bit() | edx.bit() http://codereview.chromium.org/660257 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
