http://codereview.chromium.org/660372/diff/1004/1005 File src/ast.h (right):
http://codereview.chromium.org/660372/diff/1004/1005#newcode238 src/ast.h:238: bitfields_ = (bitfields_ & ~SideEffectFreeField::mask()) | It's a little weird that there are three different ways of writing this used in this same snippet (two have different indenation, one has broken it into two statements). http://codereview.chromium.org/660372/diff/1004/1005#newcode268 src/ast.h:268: static const int SideEffectFreeFieldStart = 0; These constants don't help anything. They're used in one place in a context that should be obvious. Write: // Bitfields are <type, start, size>. class SideEffectFreeField: public BitField<bool, 0, 1>; class ExpressionSizeField: public BitField<int, 1, 5>; class StackHeightField: public BitField<int, 32 - 6>; If you want the constants, please use the coding style "kSideEffectFreeeFieldStart". http://codereview.chromium.org/660372 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
