Frankly, I don't think this is worth anyone's time. "fallthru" is a fairly common alternative spelling; people may disagree on whether they prefer it over the official spelling or not, but it's not a typo, not a bug, and not causing confusion; so just leave it. If you want to contribute to V8, that's great, but please find something more impactful than a spelling change.
On Mon, Jun 30, 2025 at 10:23 AM Clemens Backes <cleme...@chromium.org> wrote: > As noted on the CL <https://crrev.com/c/6678631>, I think renaming > everything is the right fix. > > On Mon, Jun 30, 2025 at 10:19 AM Ellison Chen < > jialiang.ellison.c...@gmail.com> wrote: > >> Hello, >> >> I'm new to the community and wanted to just change the spelling of a >> fallthrough error message, seen in this >> <https://github.com/nodejs/node/issues/58805>issue in the Node.js repo >> which suggests that the spelling should be corrected upstream, to v8. >> >> I'm looking into changing the spelling of the error messages, however, >> without changing the respective variables from fallthru to fallthrough, it >> would make it more difficult to find the respective errors and/or error >> messages. >> >> I'm thinking it would be necessary that all instances of the term >> "fallthru" should be changed to "fallthrough" in order to resolve this >> issue. >> >> Please let me know any thoughts, thanks! >> >> -- >> >> -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/v8-dev/CAKSzg3SSd4qQ7FaZ%2BHShrRpkvNJSEgqvfi4_UTTQbE-AKgLZQQ%40mail.gmail.com.
