I would expect that we have many more ASCII art comments where lines happen to end with backslashes, so I would recommend against trying to fix this as a one-off. -Wno-comment seems like a more sustainable solution.
On Mon, Sep 1, 2025 at 3:06 PM 'Matthias Liedtke' via v8-dev < [email protected]> wrote: > Ah, I forgot -Wall in my example, yeah, seems like GCC considers this > warning to be useful. > You could add -Wno-comment if you don't care about this particular warning. > AFAIK we still accept patches to fix GCC-only issues but GCC isn't > supported any more, see: > https://groups.google.com/g/v8-users/c/-vbS2agi1Kw > So if you'd like to fix it upstream, please feel free to upload a patch. > (Maybe using a block comment /* */ instead as that doesn't seem to trigger > the warning? Other options would probably look somewhat ugly.) > > On Mon, Sep 1, 2025 at 2:51 PM Jeroen Ooms <[email protected]> wrote: > >> On Mon, Sep 1, 2025 at 2:14 PM 'Matthias Liedtke' via v8-dev >> <[email protected]> wrote: >> > >> > Configuring warnings as errors will always lead to "breaking changes" >> if the set of warnings between the library (v8) and the client mismatches. >> > It seems that >> > >> > // first line \ >> > // second line >> > >> > produces a warning with -Wcomment. >> > This warning is not included in either -Wextra nor -Wpedantic, so I'm >> not sure how V8 could make sure that no client breaks if they enable >> additional warnings while also running with warnings as errors. >> >> OK. FWIW I'm seeing this on gcc 14 with -O2 -Wall . But I can patch it >> on my end if this is not a supported toolchain. >> >> -- > > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/v8-dev/CAAAk9V8NDYSH0YJ5j3eCG95xkQ%3Dy%3D-089Gvg_Q_KetZ2B%2B1LcQ%40mail.gmail.com.
