Reviewers: Erik Corry,
Description:
Don't use strcmp to test heap object pointer equality.
Please review this at http://codereview.chromium.org/668060
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M test/cctest/test-serialize.cc
Index: test/cctest/test-serialize.cc
===================================================================
--- test/cctest/test-serialize.cc (revision 4014)
+++ test/cctest/test-serialize.cc (working copy)
@@ -481,8 +481,8 @@
i += kSmallFixedArraySize) {
Object* obj = Heap::AllocateFixedArray(kSmallFixedArrayLength);
if (new_last != NULL) {
- CHECK_EQ(reinterpret_cast<char*>(obj),
- reinterpret_cast<char*>(new_last) + kSmallFixedArraySize);
+ CHECK(reinterpret_cast<char*>(obj) ==
+ reinterpret_cast<char*>(new_last) + kSmallFixedArraySize);
}
new_last = obj;
}
@@ -500,8 +500,8 @@
pointer_last = NULL;
}
if (pointer_last != NULL) {
- CHECK_EQ(reinterpret_cast<char*>(obj),
- reinterpret_cast<char*>(pointer_last) +
kSmallFixedArraySize);
+ CHECK(reinterpret_cast<char*>(obj) ==
+ reinterpret_cast<char*>(pointer_last) +
kSmallFixedArraySize);
}
pointer_last = obj;
}
@@ -517,8 +517,8 @@
data_last = NULL;
}
if (data_last != NULL) {
- CHECK_EQ(reinterpret_cast<char*>(obj),
- reinterpret_cast<char*>(data_last) + kSmallStringSize);
+ CHECK(reinterpret_cast<char*>(obj) ==
+ reinterpret_cast<char*>(data_last) + kSmallStringSize);
}
data_last = obj;
}
@@ -534,8 +534,8 @@
map_last = NULL;
}
if (map_last != NULL) {
- CHECK_EQ(reinterpret_cast<char*>(obj),
- reinterpret_cast<char*>(map_last) + kMapSize);
+ CHECK(reinterpret_cast<char*>(obj) ==
+ reinterpret_cast<char*>(map_last) + kMapSize);
}
map_last = obj;
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
