Kasper, these names mimic ECMAScript standard which uses camel case, that's why I used it in the first place. Definitely, I'd fix those if you insist.
yours, anton. On Fri, Mar 5, 2010 at 10:08 AM, <[email protected]> wrote: > > http://codereview.chromium.org/669101/diff/1/2 > File src/builtins.cc (right): > > http://codereview.chromium.org/669101/diff/1/2#newcode595 > src/builtins.cc:595: int relativeStart = 0; > Don't use camelCase for local variables. > > http://codereview.chromium.org/669101/diff/1/2#newcode602 > src/builtins.cc:602: int actualStart = (relativeStart < 0) ? Max(len + > relativeStart, 0) > Don't use camelCase for local variables. > > http://codereview.chromium.org/669101/diff/1/2#newcode609 > src/builtins.cc:609: int deleteCount = len; > Don't use camelCase for local variables. > > http://codereview.chromium.org/669101/diff/1/2#newcode618 > src/builtins.cc:618: int actualDeleteCount = Min(Max(deleteCount, 0), > len - actualStart); > Don't use camelCase for local variables. > > http://codereview.chromium.org/669101/diff/1/2#newcode648 > src/builtins.cc:648: int itemCount = (n_arguments > 1) ? (n_arguments - > 2) : 0; > Don't use camelCase for local variables. > > http://codereview.chromium.org/669101 > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
