Reviewers: Søren Gjesse,
Message:
[email protected]
p.s. I finally realized, that I needn't submit issue for each and every
TODO,
but instead I can have one issue for all LiveEdit feature.
Description:
Quick fix for r4045
Please review this at http://codereview.chromium.org/668203
Affected files:
M src/liveedit.cc
M test/mjsunit/fuzz-natives.js
Index: src/liveedit.cc
diff --git a/src/liveedit.cc b/src/liveedit.cc
index
09970ccf9950843aa86b85e4de88f00d312af290..2c27e9f0dd7c9d81fb31b94a1bfea936aa57c071
100644
--- a/src/liveedit.cc
+++ b/src/liveedit.cc
@@ -44,7 +44,7 @@ namespace internal {
static void CompileScriptForTracker(Handle<Script> script) {
const bool is_eval = false;
const bool is_global = true;
- // TODO: support extensions.
+ // TODO(635): support extensions.
Extension* extension = NULL;
PostponeInterruptsScope postpone;
@@ -385,7 +385,7 @@ static int TranslatePosition(int original_position,
Handle<JSArray> position_change_array) {
int position_diff = 0;
int array_len = Smi::cast(position_change_array->length())->value();
- // TODO: binary search may be used here
+ // TODO(635): binary search may be used here
for (int i = 0; i < array_len; i += 3) {
int chunk_start =
Smi::cast(position_change_array->GetElement(i))->value();
Index: test/mjsunit/fuzz-natives.js
diff --git a/test/mjsunit/fuzz-natives.js b/test/mjsunit/fuzz-natives.js
index
687a7d05f27cba4e8f76f9a51bd43a8488066d9d..730f7b41f5edb3cef7e886b03369c04c78508f3e
100644
--- a/test/mjsunit/fuzz-natives.js
+++ b/test/mjsunit/fuzz-natives.js
@@ -150,7 +150,15 @@ var knownProblems = {
"DeleteHandleScopeExtensions": true,
// That can only be invoked on Array.prototype.
- "FinishArrayPrototypeSetup": true
+ "FinishArrayPrototypeSetup": true,
+
+ // LiveEdit feature is under development currently and has fragile input.
+ "LiveEditFindSharedFunctionInfosForScript": true,
+ "LiveEditGatherCompileInfo": true,
+ "LiveEditReplaceScript": true,
+ "LiveEditReplaceFunctionCode": true,
+ "LiveEditRelinkFunctionToScript": true,
+ "LiveEditPatchFunctionPositions": true
};
var currentlyUncallable = {
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
