I like it. I would like to understand why the method to call the special functions is called at a different time on ARM before putting this in. Other than that it LGTM.
http://codereview.chromium.org/660298/diff/33/1027 File src/bootstrapper.cc (right): http://codereview.chromium.org/660298/diff/33/1027#newcode1477 src/bootstrapper.cc:1477: Object* old_value = prototype->GetProperty(*key); Since everything else is in handles here, could you use the handle-based version of GetProperty as well? Handle<Object> old_value = GetProperty(prototype, key); http://codereview.chromium.org/660298/diff/33/1027#newcode1478 src/bootstrapper.cc:1478: // On ARM we sometimes call this method before installing natives. But we do call it after installing natives as well, right? Why do we call it before installing natives on ARM and not on the other platforms? I find that a little puzzling. http://codereview.chromium.org/660298/diff/33/1028 File src/builtins.cc (right): http://codereview.chromium.org/660298/diff/33/1028#newcode322 src/builtins.cc:322: class FastElementsArrayCheck { I would make this a static method 'IsJSArrayWithFastElements' with a bool result type and a couple of out parameters. http://codereview.chromium.org/660298 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
