LGTM.
http://codereview.chromium.org/660449/diff/3007/3010 File src/data-flow.cc (right): http://codereview.chromium.org/660449/diff/3007/3010#newcode736 src/data-flow.cc:736: prop->obj()->set_num(AstNode::kNoNumber); We should remove depending on certain nodes having no number as a separate change. http://codereview.chromium.org/660449/diff/3007/3011 File src/data-flow.h (right): http://codereview.chromium.org/660449/diff/3007/3011#newcode116 src/data-flow.h:116: void Append(AstNode* instruction); I'm not sure if overloading the name Append helps readability. I'd prefer using AppendInstruction, AppendNode, AppendFlowGraph. http://codereview.chromium.org/660449/diff/3007/3011#newcode125 src/data-flow.h:125: // and merged, so the graph remains single-entry, single-exit. Maybe mentions that left is always the true-branch and right is the false branch. http://codereview.chromium.org/660449/diff/3007/3011#newcode165 src/data-flow.h:165: void MarkWith(bool mark) { mark_ = mark; } Name this functions consistently with other accessors mark() and set_mark() http://codereview.chromium.org/660449 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
