LGTM with changes.
http://codereview.chromium.org/825004/diff/1/2 File test/cctest/test-dtoa.h (right): http://codereview.chromium.org/825004/diff/1/2#newcode4 test/cctest/test-dtoa.h:4: char* buffer, int sign, int length, int point) { One parameter per line. http://codereview.chromium.org/825004/diff/1/2#newcode63 test/cctest/test-dtoa.h:63: double v, char* buffer, int sign, int length, int point) { Format formal parameters one per line. http://codereview.chromium.org/825004/diff/1/2#newcode73 test/cctest/test-dtoa.h:73: if (v == ComposeDouble(buffer, sign, length - 1, point)) Put braces around a statement if it is not on the same line as if. http://codereview.chromium.org/825004 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
