On 2010/03/11 06:14:45, antonm wrote:
LGTM.
You might want to add another assert (with slight rework) into
Log::GetLogLines
in src/log-utils.cc:
ln. 198: ASSERT(end_pos - dest_buf > 1);
(maybe adding actual_size > 0)
to check that you never trim the line completely.
Thanks. Added ASSERT(actual_size > 0). http://codereview.chromium.org/799008 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
