LGTM.
http://codereview.chromium.org/876001/diff/1/4 File src/data-flow.cc (right): http://codereview.chromium.org/876001/diff/1/4#newcode1970 src/data-flow.cc:1970: PrintF("Def[%s] = {%d", *name, j); I think you could just write PrintF("Def[%s] = {%d", *var->name()->ToCString(), j); here. http://codereview.chromium.org/876001/diff/1/5 File src/data-flow.h (right): http://codereview.chromium.org/876001/diff/1/5#newcode134 src/data-flow.h:134: ReachingDefinitionsData() : definitions_(NULL) {} I'd initialize killed_ and generated also to NULL here. http://codereview.chromium.org/876001/diff/1/5#newcode137 src/data-flow.h:137: BitVector* killed_; It's just a naming issue, but we could shorten these to kill_ and gen_ since you refer to them as GEN and KILL in the comments as well. http://codereview.chromium.org/876001 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
