Reviewers: sgjesse,
Description:
Use this->foo() in place of foo() in some places to appease pedantic
compilers.
Gory details are here:
http://blog.llvm.org/2009/12/dreaded-two-phase-name-lookup.html
Please review this at http://codereview.chromium.org/894001
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M src/objects.h
M src/utils.h
Index: src/objects.h
===================================================================
--- src/objects.h (revision 4095)
+++ src/objects.h (working copy)
@@ -2154,24 +2154,24 @@
// Returns the value at entry.
Object* ValueAt(int entry) {
- return get(HashTable<Shape, Key>::EntryToIndex(entry)+1);
+ return this->get(HashTable<Shape, Key>::EntryToIndex(entry)+1);
}
// Set the value for entry.
void ValueAtPut(int entry, Object* value) {
- set(HashTable<Shape, Key>::EntryToIndex(entry)+1, value);
+ this->set(HashTable<Shape, Key>::EntryToIndex(entry)+1, value);
}
// Returns the property details for the property at entry.
PropertyDetails DetailsAt(int entry) {
ASSERT(entry >= 0); // Not found is -1, which is not caught by get().
return PropertyDetails(
- Smi::cast(get(HashTable<Shape, Key>::EntryToIndex(entry) + 2)));
+ Smi::cast(this->get(HashTable<Shape, Key>::EntryToIndex(entry) +
2)));
}
// Set the details for entry.
void DetailsAtPut(int entry, PropertyDetails value) {
- set(HashTable<Shape, Key>::EntryToIndex(entry) + 2, value.AsSmi());
+ this->set(HashTable<Shape, Key>::EntryToIndex(entry) + 2,
value.AsSmi());
}
// Sorting support
@@ -2194,7 +2194,7 @@
// Accessors for next enumeration index.
void SetNextEnumerationIndex(int index) {
- fast_set(this, kNextEnumerationIndexIndex, Smi::FromInt(index));
+ this->fast_set(this, kNextEnumerationIndexIndex, Smi::FromInt(index));
}
int NextEnumerationIndex() {
Index: src/utils.h
===================================================================
--- src/utils.h (revision 4095)
+++ src/utils.h (working copy)
@@ -396,7 +396,7 @@
if (this == &rhs) return *this;
Vector<T>::operator=(rhs);
memcpy(buffer_, rhs.buffer_, sizeof(T) * kSize);
- set_start(buffer_);
+ this->set_start(buffer_);
return *this;
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
