LGTM, with a suggestion.
http://codereview.chromium.org/885004/diff/1/3 File src/compiler.cc (right): http://codereview.chromium.org/885004/diff/1/3#newcode98 src/compiler.cc:98: if (variable_count > 0 && builder.definitions()->length() > 0) { Hmm. I'd let the ReachingDefinitions class check the definitions() length itself. http://codereview.chromium.org/885004/diff/1/2 File src/data-flow.cc (right): http://codereview.chromium.org/885004/diff/1/2#newcode2064 src/data-flow.cc:2064: ASSERT(!definitions_->is_empty()); I'd leave this check here. http://codereview.chromium.org/885004 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
