Reviewers: Mads Ager,
Message:
Mads,
sorry, I just forgot to fix some of your comments for
http://codereview.chromium.org/669061/show
Description:
Some cosmetic issues.
Please review this at http://codereview.chromium.org/903004
Affected files:
M src/array.js
M src/ia32/stub-cache-ia32.cc
Index: src/array.js
diff --git a/src/array.js b/src/array.js
index
e2aa4ad116724922d55dc7b9ffa129b967f23596..95d4ada1646e41d415b43e468717638af1119124
100644
--- a/src/array.js
+++ b/src/array.js
@@ -1107,7 +1107,7 @@ function SetupArray() {
if (specialFunctions.hasOwnProperty(name)) {
f = specialFunctions[name];
}
- if (arguments.length == 3) {
+ if (!IS_UNDEFINED(len)) {
%FunctionSetLength(f, len);
}
return f;
Index: src/ia32/stub-cache-ia32.cc
diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc
index
3c50f0d60449e6431363a4cee7c2ebf10459747e..902a5b81065a0ecfef42f537c49b9b951f110475
100644
--- a/src/ia32/stub-cache-ia32.cc
+++ b/src/ia32/stub-cache-ia32.cc
@@ -1247,7 +1247,7 @@ Object*
CallStubCompiler::CompileArrayPushCall(Object* object,
// Check that the elements are in fast mode (not dictionary).
__ cmp(FieldOperand(ebx, HeapObject::kMapOffset),
- Immediate(Factory::fixed_array_map()));
+ Immediate(Factory::fixed_array_map()));
__ j(not_equal, &miss);
if (argc == 1) { // Otherwise fall through to call builtin.
@@ -1277,7 +1277,7 @@ Object*
CallStubCompiler::CompileArrayPushCall(Object* object,
__ mov(ecx, Operand(esp, argc * kPointerSize));
__ mov(Operand(edx, 0), ecx);
- // Check if wrote not a smi.
+ // Check if value is a smi.
__ test(ecx, Immediate(kSmiTagMask));
__ j(not_zero, &with_rset_update);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
