http://codereview.chromium.org/945002/diff/1/2 File src/ia32/stub-cache-ia32.cc (right):
http://codereview.chromium.org/945002/diff/1/2#newcode1304 src/ia32/stub-cache-ia32.cc:1304: const int allocation_delta = 4; Please follow Google C++ style naming conventions: kAllocationDelta. http://codereview.chromium.org/945002/diff/1/2#newcode1317 src/ia32/stub-cache-ia32.cc:1317: // We fit. Don't forget to restore edx. Could you move the restore comment to where you actually restore edx and explicitly state that edx needs to hold the receiver when pushing the element. http://codereview.chromium.org/945002/diff/1/2#newcode1323 src/ia32/stub-cache-ia32.cc:1323: Immediate(Factory::undefined_value())); Shouldn't you fill the rest of the backing store with holes? http://codereview.chromium.org/945002 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
