LGTM otherwise.
http://codereview.chromium.org/965001/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/965001/diff/1/2#newcode1927 src/ia32/codegen-ia32.cc:1927: overwrite_mode, false); Why pass false here? Should it be no_negative_zero as well? http://codereview.chromium.org/965001/diff/1/2#newcode1963 src/ia32/codegen-ia32.cc:1963: overwrite_mode, false); Why pass false here? Should it be no_negative_zero as well? http://codereview.chromium.org/965001/diff/1/5 File src/rewriter.cc (right): http://codereview.chromium.org/965001/diff/1/5#newcode580 src/rewriter.cc:580: node->right()->set_no_negative_zero(true); // Only [[HasIntance]] gets it. Typo in comment ->HasInstance http://codereview.chromium.org/965001 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
