Lasse, sorry, I've submitted the CL already. Sending another CL to you.
http://codereview.chromium.org/954001/diff/4001/5002 File src/builtins.cc (right): http://codereview.chromium.org/954001/diff/4001/5002#newcode742 src/builtins.cc:742: if (!IsJSArrayWithFastElements(receiver_obj, &receiver_elms) On 2010/03/15 11:45:41, Lasse Reichstein wrote:
I personally don't like test functions with side effects. Could you
just do the
assignments after the if-statement instead?
It used to save some cycles, at least in previous versions. If you like, I can run another experiment to see how much (if anything) does it buy us now. http://codereview.chromium.org/954001/diff/4001/5002#newcode755 src/builtins.cc:755: ASSERT(receiver_len <= (Smi::kMaxValue - arg_len)); On 2010/03/15 11:45:41, Lasse Reichstein wrote:
Maybe comment that this assertion holds because both arrays have fast
elements
(possibly rewriting it in terms of FixedArray::kMaxLength).
Done http://codereview.chromium.org/954001/diff/4001/5002#newcode758 src/builtins.cc:758: if (result_len > FixedArray::kMaxSize) { On 2010/03/15 11:45:41, Lasse Reichstein wrote:
FixedArray::kMaxLength (length is in elements, size is in bytes).
Oh yes, thanks a lot for spotting this. http://codereview.chromium.org/954001 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
