LGTM, and I'll ignore the other CL.
http://codereview.chromium.org/1036002/diff/1/2 File src/builtins.cc (right): http://codereview.chromium.org/1036002/diff/1/2#newcode748 src/builtins.cc:748: result_len += len; Might want comment stating why this can't overflow: (FixedArray::kMaxLength < (max positive int / 2)), so being <= kMaxLength means that adding another array's length won't overflow. http://codereview.chromium.org/1036002 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
