Bonus comment.
http://codereview.chromium.org/1036002/diff/1/2 File src/builtins.cc (right): http://codereview.chromium.org/1036002/diff/1/2#newcode741 src/builtins.cc:741: FixedArray* elms = NULL; elms isn't used anywhere, so the function with side-effect is wasted here. Wouldn't it be simpler to just check manually: if(!arg->IsJSArray() || !JSArray::cast(arg)->HasFastElements()) { http://codereview.chromium.org/1036002 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
