LGTM, with a couple of nits. Kevin is out of town at the moment. The port looks correct to me.
We need to get rid of the relocation info hack. I'm fine with doing that in a separate change, but we need to do it. Can we measure if there is any visible
impact of not resetting the binary operation ICs at GC time? http://codereview.chromium.org/845002/diff/4001/3002 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/845002/diff/4001/3002#newcode8747 src/x64/codegen-x64.cc:8747: if (op_ == Token::ADD) { Indentation is off here. http://codereview.chromium.org/845002/diff/4001/3002#newcode8919 src/x64/codegen-x64.cc:8919: // Generate an unreachable reference to the DEFAULT stub so that it can be This still feels like a nasty hack to me. Does the clearing matter? We need to experiment with this and get rid of this hack somehow. http://codereview.chromium.org/845002/diff/4001/3002#newcode8964 src/x64/codegen-x64.cc:8964: // edx, eax. ia32 register names. http://codereview.chromium.org/845002/diff/4001/3002#newcode9020 src/x64/codegen-x64.cc:9020: HandleScope scope; This returns a handle from a destroyed handle scope which is not GC safe. The caller of GetBinaryOpStub already has a handle scope, so just remove this one. http://codereview.chromium.org/845002 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
