Reviewers: Søren Gjesse,

Message:
Søren,

may you have a look?

Alas, I failed to run it through try bots---let's fix this issue anyway and see
if suppression could be safely removed.

Description:
Properly release zero-length Vectors.

Please review this at http://codereview.chromium.org/987004

Affected files:
  M src/utils.h


Index: src/utils.h
diff --git a/src/utils.h b/src/utils.h
index 3c8d873edd33d46a98e8475d29f2cdba0523603b..4a9d871ce8646068497a49095f1bc5da003d92c6 100644
--- a/src/utils.h
+++ b/src/utils.h
@@ -341,8 +341,8 @@ class Vector {
   // Releases the array underlying this vector. Once disposed the
   // vector is empty.
   void Dispose() {
-    if (is_empty()) return;
     DeleteArray(start_);
+    if (is_empty()) return;
     start_ = NULL;
     length_ = 0;
   }


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to