Revision: 4174
Author: [email protected]
Date: Thu Mar 18 02:08:24 2010
Log: Add test cases for fast smi loops.
Review URL: http://codereview.chromium.org/1014007
http://code.google.com/p/v8/source/detail?r=4174
Modified:
/branches/bleeding_edge/src/ia32/codegen-ia32.cc
/branches/bleeding_edge/test/mjsunit/compiler/loopcount.js
=======================================
--- /branches/bleeding_edge/src/ia32/codegen-ia32.cc Wed Mar 17 09:39:29
2010
+++ /branches/bleeding_edge/src/ia32/codegen-ia32.cc Thu Mar 18 02:08:24
2010
@@ -3727,10 +3727,11 @@
CheckStack(); // TODO(1222600): ignore if body contains calls.
- // If we have (a) a loop with a compile-time constant trip count
- // and (b) the loop induction variable is not assignend inside the
- // loop we update the number type of the induction variable to be smi.
-
+ // We know that the loop index is a smi if it is not modified in the
+ // loop body and it is checked against a constant limit in the loop
+ // condition. In this case, we reset the static type information of the
+ // loop index to smi before compiling the body, the update expression,
and
+ // the bottom check of the loop condition.
if (node->is_fast_smi_loop()) {
// Set number type of the loop variable to smi.
Slot* slot = node->loop_variable()->slot();
@@ -3763,8 +3764,8 @@
}
}
- // The update expression resets the type of the loop variable. So we
- // set it to smi before compiling the test expression.
+ // Set the type of the loop variable to smi before compiling the test
+ // expression if we are in a fast smi loop condition.
if (node->is_fast_smi_loop()) {
// Set number type of the loop variable to smi.
Slot* slot = node->loop_variable()->slot();
=======================================
--- /branches/bleeding_edge/test/mjsunit/compiler/loopcount.js Wed Mar 17
09:39:29 2010
+++ /branches/bleeding_edge/test/mjsunit/compiler/loopcount.js Thu Mar 18
02:08:24 2010
@@ -54,5 +54,24 @@
}
assertEquals(-0x40000001, f5());
+
function f6() { var x = 0x3fffffff; x++; return x+1; }
assertEquals(0x40000001, f6());
+
+
+function f7() {
+ var i;
+ for (i = 0x3ffffffd; i <= 0x3ffffffe; i++) {}
+ i++; i = i + 1;
+ return i;
+}
+assertEquals(0x40000001, f7());
+
+
+function f8() {
+ var i;
+ for (i = 0x3ffffffd; i <= 0x3fffffff; i++) {}
+ i++; i++;
+ return i;
+}
+assertEquals(0x40000002, f8());
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
