Thanks for the review!
http://codereview.chromium.org/1025004/diff/1/4 File include/v8-debug.h (right): http://codereview.chromium.org/1025004/diff/1/4#newcode249 include/v8-debug.h:249: */ On 2010/03/18 07:31:13, Søren Gjesse wrote:
Please extend the comment here to say that the receiver will be the
debugger
context global object, but that that is subject to change.
Done. http://codereview.chromium.org/1025004/diff/1/4#newcode309 include/v8-debug.h:309: * debugger context. On 2010/03/18 07:31:13, Søren Gjesse wrote:
I think there should be a comment here that the content of the
debugger context
is subject to change.
Done. http://codereview.chromium.org/1025004/diff/1/3 File src/debug.cc (right): http://codereview.chromium.org/1025004/diff/1/3#newcode2494 src/debug.cc:2494: Handle<Object>(Debug::debug_context_->global()), On 2010/03/18 07:31:13, Søren Gjesse wrote:
I think we should use global_proxy() here.
Done. http://codereview.chromium.org/1025004 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
