Perhaps we could get Florian Loitsch to look at this one? 2010/3/18 <[email protected]>
> Reviewers: Mads Ager, > > Message: > StringToNumber is called ~10M times in SunSpider (according to my > measurements) > but vast majority of arguments are junk values. Tests that heavy convert > numbers > spend up to 20% their time allocating/deallocating memory in the C heap. > > In addition to this change I'm going to add a fast check for obviously junk > string (I'm deciding if it should be added it into the > Runtime_NumberToString to > inlined). > > Description: > StringToDouble rewritten not using String::Get and memory allocations. > > It converts the number to "canonical" form removing insignificant digits, > leading zerroes and spaces what guarantees to fit a fixed size buffer and > does not changes result of strtod. > > > Please review this at http://codereview.chromium.org/1096002 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/conversions.cc > M test/cctest/test-conversions.cc > M test/mjsunit/str-to-num.js > > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
