Some comments.
http://codereview.chromium.org/998001/diff/18009/25007 File src/ast.cc (right): http://codereview.chromium.org/998001/diff/18009/25007#newcode599 src/ast.cc:599: // are already numbered. Assert that we only copy AstNodes before node numbers are assigned. http://codereview.chromium.org/998001/diff/18009/25007#newcode730 src/ast.cc:730: Couldn't conditional expressions be supported easily? I would think they might show up in statement bodies. Why do properties and calls not need to be cloned when the deep copy is made? Or do they have no fields that need copying explicitly? http://codereview.chromium.org/998001/diff/18009/25008 File src/parser.cc (right): http://codereview.chromium.org/998001/diff/18009/25008#newcode3850 src/parser.cc:3850: // when peeling or unrolling such a loop. Should we check for object literals bigger than a certain size as well, or is that not a problem? http://codereview.chromium.org/998001/diff/18009/25002 File src/variables.h (left): http://codereview.chromium.org/998001/diff/18009/25002#oldcode45 src/variables.h:45: Why is StaticType not copied and assigned by value? Is it likely that it will become more complex in the future? http://codereview.chromium.org/998001 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
