LGTM as a start.
http://codereview.chromium.org/1164002/diff/1/10 File src/SConscript (right): http://codereview.chromium.org/1164002/diff/1/10#newcode131 src/SConscript:131: fast-codegen.cc I think these files in the main src/ directory should either always come before or always after the ones in subdirectories (preferably before). If you alphabetize them along with the rest, some will be before and some after and it's probably better to have them together. http://codereview.chromium.org/1164002/diff/1/18 File src/arm/jump-target-arm.cc (right): http://codereview.chromium.org/1164002/diff/1/18#newcode205 src/arm/jump-target-arm.cc:205: UNREACHABLE(); UNIMPLEMENTED? http://codereview.chromium.org/1164002/diff/1/9 File src/jump-target-light-inl.h (right): http://codereview.chromium.org/1164002/diff/1/9#newcode37 src/jump-target-light-inl.h:37: UNREACHABLE(); UNIMPLEMENTED? http://codereview.chromium.org/1164002 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
