Please add a test case to test-api.cc.
http://codereview.chromium.org/1094002/diff/6001/7003 File include/v8.h (right): http://codereview.chromium.org/1094002/diff/6001/7003#newcode2313 include/v8.h:2313: /** The comments have not been updated. They still mention major GC's. Please keep the old comments together with the old functions, and extend these comments saying that these API's are deprecated and that xxx should be used instead. http://codereview.chromium.org/1094002/diff/6001/7003#newcode2320 include/v8.h:2320: static int SetGCPrologueCallback(GCPrologueCallback callback); How about changing enum GCType into a bitfield enum GCType { kGCTypeScavenge = 1 << 0, kGCTypeMarkSweep = 1 << 2, kGCTypeMarkCompact = 1 << 3, kGCTypeAll = kGCTypeScavenge | kGCTypeMarkSweep | kGCTypeMarkCompact }; and add an argument to these AddGCXXX to indicate which GC's to receive a callback for AddGCPrologueCallback(GCType types, GCPrologueCallback callback) This way we could use this new API for what the SetGlobalGCPrologueCallback and SetGlobalGCEpilogueCallback does now and be able to retire these API's at some point. http://codereview.chromium.org/1094002/diff/6001/7002 File src/heap.h (right): http://codereview.chromium.org/1094002/diff/6001/7002#newcode692 src/heap.h:692: static void SetGlobalGCPrologueCallback(GCCallback callback) { I don't understand this ASSERT. Please always use != NULL or == NULL when dealing with pointers. http://codereview.chromium.org/1094002/diff/6001/7002#newcode696 src/heap.h:696: static void SetGlobalGCEpilogueCallback(GCCallback callback) { Ditto. http://codereview.chromium.org/1094002/diff/6001/7002#newcode1068 src/heap.h:1068: if (gc_callbacks_) { (gc_callbacks_ != NULL) instead of just (gc_callbacks_). Same for the other uses of (gc_callbacks_) and (!gc_callbacks_) including the ones in ASSERT. http://codereview.chromium.org/1094002/diff/6001/7002#newcode1074 src/heap.h:1074: if (!isEmpty()) Please add {}' for this if. http://codereview.chromium.org/1094002 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
