When I run tools/test.py --simulator=mips it turns out that the test
test-mips/MIPS_function_calls fails as it hits a large number of
UNIMPLEMENTED_MIPS. Is Was that the intention?
Also two more comments:
1. Regarding writing below the stack pointer in
MacroAssembler::SetupAlignedCall. I don't know how MIPS Linux uses the stack
when handling interrupts, so it might not actually cause problems. However I
think that even if that is the case it should be avoided - even it we have
to
generate a bit more code.
2. I think you are right that the code generator should not use the at
register
and allow assembler/macro assembler to use it at will. on x64 we have
reserved a
register as kScratchRegister for use by the code generator, but that might
not
be relevant for you.
And finally for comitting, are you doing this work while for Sigma Designs
Inc.?
http://codereview.chromium.org/1018001/diff/45001/46014
File test/cctest/test-mips.cc (right):
http://codereview.chromium.org/1018001/diff/45001/46014#newcode38
test/cctest/test-mips.cc:38: TEST(MIPS_function_calls) {
Please rename the test to MIPSFunctionCall.
http://codereview.chromium.org/1018001/diff/45001/46014#newcode42
test/cctest/test-mips.cc:42: const char* c_source = "function foo() {
return 0x1234; }; foo();";
Can't you do without ::v8:: here?
http://codereview.chromium.org/1018001
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
