LGTM if you increase the buffer size to the max-double string. Please upload a new version here before committing (just to make comparison easier).
http://codereview.chromium.org/1096002/diff/21004/27003 File src/conversions.cc (right): http://codereview.chromium.org/1096002/diff/21004/27003#newcode123 src/conversions.cc:123: int StringInputBufferIterator::operator * () const { Convention v8 seems to be to put the attach the operator: operator*() http://codereview.chromium.org/1096002 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
