First round of comments.
http://codereview.chromium.org/1159005/diff/1/2 File src/ast.cc (right): http://codereview.chromium.org/1159005/diff/1/2#newcode647 src/ast.cc:647: return expression()->IsPrimitive(); This should be return !expression()->IsPrimitive(); right? http://codereview.chromium.org/1159005/diff/1/3 File src/ast.h (right): http://codereview.chromium.org/1159005/diff/1/3#newcode292 src/ast.h:292: int is_live() const { return LiveField::decode(bitfields_); } This should return a bool. http://codereview.chromium.org/1159005/diff/1/5 File src/data-flow.cc (right): http://codereview.chromium.org/1159005/diff/1/5#newcode2082 src/data-flow.cc:2082: List<AstNode*> stack; Maybe set an initial size to avoid resizing too often? http://codereview.chromium.org/1159005 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
