I'll try to do---allocate a huge fixed array in old space and clone it. But I'd like to have the fix first, if you don't mind.
yours, anton. On Wed, Mar 24, 2010 at 12:20 PM, Kasper Lund <[email protected]> wrote: > Is there any way you could add a regression test case for this, Anton? > > Cheers, > Kasper > > On Wed, Mar 24, 2010 at 10:08 AM, <[email protected]> wrote: >> Reviewers: Mads Ager, Søren Gjesse, >> >> Message: >> Guys, >> >> may you have a look? >> >> Description: >> Pass the proper number of fields to update remembered set for. >> >> By oversight kPointerSize more fields were passed. >> >> BUG=39128 >> >> Please review this at http://codereview.chromium.org/1265001 >> >> Affected files: >> M src/heap.cc >> >> >> Index: src/heap.cc >> diff --git a/src/heap.cc b/src/heap.cc >> index >> 13ffa29c36b7d5eac279f06ad890b395a8696101..a9754ce057837968f482b1920e1e8fc416f972e0 >> 100644 >> --- a/src/heap.cc >> +++ b/src/heap.cc >> @@ -2648,7 +2648,7 @@ Object* Heap::CopyJSObject(JSObject* source) { >> // Update write barrier for all fields that lie beyond the header. >> RecordWrites(clone_address, >> JSObject::kHeaderSize, >> - object_size - JSObject::kHeaderSize); >> + (object_size - JSObject::kHeaderSize) / kPointerSize); >> } else { >> clone = new_space_.AllocateRaw(object_size); >> if (clone->IsFailure()) return clone; >> >> >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> >> To unsubscribe from this group, send email to >> v8-dev+unsubscribegooglegroups.com or reply to this email with the words >> "REMOVE ME" as the subject. >> > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > > To unsubscribe from this group, send email to > v8-dev+unsubscribegooglegroups.com or reply to this email with the words > "REMOVE ME" as the subject. > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
