LGTM.
http://codereview.chromium.org/1225003/diff/3001/4001 File src/conversions.cc (left): http://codereview.chromium.org/1225003/diff/3001/4001#oldcode298 src/conversions.cc:298: ASSERT(buffer_pos < buffer_size); I would probably have preferred a solution where we could keep bounds checks in debug mode, but for now this is okay (since we don't have the bounds checks in the other places). I would consider rewriting most of this code using a Vector<char> rather than char*. http://codereview.chromium.org/1225003 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
